Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reporter): format stack with 1-based column #3325

Merged
merged 1 commit into from
Jun 17, 2019
Merged

fix(reporter): format stack with 1-based column #3325

merged 1 commit into from
Jun 17, 2019

Conversation

segrey
Copy link
Contributor

@segrey segrey commented Jun 5, 2019

Columns in original stack are 1-based, but
SourceMapConsumer.prototype.originalPositionFor(generatedPosition)
accepts 0-based column and returns 0-based column too.
This change converts columns from 1-based to 0-based forth and back.

Closes #3324

Columns in original stack are 1-based, but
SourceMapConsumer.prototype.originalPositionFor(generatedPosition)
accepts 0-based column and returns 0-based column too.
This change converts columns from 1-based to 0-based forth and back.

Closes #3324
@segrey
Copy link
Contributor Author

segrey commented Jun 5, 2019

The Travis CI build was failed for "Node.js 8" configuration in the same way as it fails for karma master (https://travis-ci.org/karma-runner/karma). So, seems this failed check can be skipped.

@segrey
Copy link
Contributor Author

segrey commented Jun 14, 2019

@johnjbarton Could you please take a look at this PR? It helps IDE to annotate correctly method call where assertion is failed.
(The failed Travis build is not caused by this change.)

@johnjbarton johnjbarton merged commit 182c04d into karma-runner:master Jun 17, 2019
@segrey segrey deleted the fix-3324 branch June 18, 2019 20:45
@segrey
Copy link
Contributor Author

segrey commented Jun 18, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect column in stack trace with original file
2 participants